argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.01k stars 5.49k forks source link

feat: Add basic support for git tag path prefixes #20948

Open chzar opened 2 hours ago

chzar commented 2 hours ago

TL;DR This PR changes the resolveSemverRevision() to tolerate a path prefix before the semantic version.

# example
targetRevision: 'foo/bar/ >= v0.0.0-rc0'

This change is useful for teams that:

Checklist:

bunnyshell[bot] commented 2 hours ago

:white_check_mark: Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-lnnaku.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-lnnaku.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

chzar commented 1 hour ago

To me this change is not so much a feature but rather a logic change to accept a path prefix alongside semantic version tags - so I have not created an enhancement proposal. Happy to do so if the maintainers believe otherwise.