search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.75k stars 5.41k forks source link

Display diff in history #2355

Open alexec opened 5 years ago

alexec commented 5 years ago

Is your feature request related to a problem? Please describe.

I'd like to understand the difference between a previous deployment and the current (or next) deployment. That way I can know what changed, or what will change if I rollback. This will give me more confidence that the rollback will do what I expect.

Describe the solution you'd like

Like "App Diff", can we have diff in history?

OmerKahani commented 4 years ago

How will the UI be like: add a button in the history that will switch the sidebar to the app diff view?

hawksight commented 4 years ago

This would be really helpful when inspecting releases. Maybe when you open the history and rollback side bar, there is a switcher or buttons at the top of that pane a bit like you have in the application:

Screenshot from 2020-09-08 16-33-02

Obviously different icons, but it would be nice to switch from the 'parameters' view (as it is now) to the 'diff' view. Where it'd show the diff for a given revision.

Or even just a switch or toggle would work if there would only be two views.

Once switched, rather than showing the parameters (which is still useful), instead it would show the diff output. The view you get when you click app diff button before manually syncing a change.

wreed4 commented 2 years ago

Having this feature in the CLI alone would be really amazing. I'm looking for this ability currently to prove that a release to staging was good, and I want the diff of what was applied last, but I can't find out how to get it other than roll back and then get the diff and roll forward again. which isn't really an option.

ciiay commented 2 years ago

I'd like to work on this.

ciiay commented 2 years ago

@alexec @alexmt Can we give a second thought about if this is a #good first issue? After taking a closer look at this issue, it seems that to achieve the request we will need to update the API side logic to cache the code on previous deployment. Not sure if it's too expensive to do so now. Let me know what you think. Thanks!

caio-eiq commented 1 year ago

Does anyone have a workaround or a way of visualizing app diff from previous syncs or it's pending on this feature request?

adamency commented 1 week ago

@alexec @OmerKahani @ciiay Do we have any update on this feature ?IMHO being able to see diffs of past deployments with current one is a necessary feature for the rollback feature to be actually production-ready. It is very clunky to use rollbacks in the dark without knowing precisely what changes will happen.

As a side note, it would be possible to implement a basic version of this feature by simply doing a helm template of the revision in question and diff-ing it with the current desired state.