argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.82k stars 5.44k forks source link

Support Jsonnet Jpaths #2679

Closed anarcher closed 4 years ago

anarcher commented 4 years ago

Summary

Support jsonnet jpaths(jsonnet -J) for argocd apps

Motivation

jsonnet supports jpaths . It can be useful with jsonnet based app. specially if we use it with jsonnet-bundler (https://github.com/jsonnet-bundler/jsonnet-bundler)

Proposal

spec:
  source:
    directory:
      jsonnet:
        jpaths:
        - ../../vendor
        - ../../lib
    path: baseapp/environments/default
    repoURL: https://github.com/anarcher/hello-tk.git
    targetRevision: HEAD
alexec commented 4 years ago

@anarcher I've reviewed your PR and it looks a bit like the kind of problem people solve using custom plugins. Have you considered that please?

https://argoproj.github.io/argo-cd/operator-manual/custom_tools/

anarcher commented 4 years ago

@alexec Thanks for the review. Generally, I agree that using custom tools for supporting jpaths is a good option. My thought was that jpaths is available option of Jsonnet so native support with Argocd makes sense. :-) But if you feel this issue is not necessary, I am ok to close this issue and PR :->