argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.71k stars 5.4k forks source link

ArgoCD UI just keeps on refreshing even if the Pod is in Failed/Completed State #4721

Closed rajivml closed 3 years ago

rajivml commented 3 years ago

Environment: 1.7.8

Summary

HI,

When we are on the Pod logs page, even if the job is in failed/completed state, the UI just keeps on polling the backend to fetch the latest logs and it makes copying the logs very difficult not difficult but almost impossible

Motivation

Am trying to copy the logs from pod logs UI , but UI just keeps on polling backend and content is getting refreshed even after the Pod is in Failed/Completed state

Proposal

Stop polling when the job is failed/completed state

rajivml commented 3 years ago

Recorded a short demo here about the issue where you can notice that the pod is in completed state but the UI is continuously looking for latest log updates resulting in not allowing me to browse through the entire log or copy the logs

https://uipath.zoom.us/rec/share/GfcDP51kTdsTjI9SM0pZLLsZV-WGdTDCg4eHKkxciEon-J6_25Y6VBm-atDZbDMl.2VqYwGrUItQDUfE0

Access Passcode: 7Zeq!#AD

jannfis commented 3 years ago

This might be the for the same reason as reported in #4619, which was fixed by #4696 to be released with v1.8.

rajivml commented 3 years ago

Thanks @jannfis for looking into this, I will use 1.7.4 for my demo in that case

rajivml commented 3 years ago

@jannfis I have downgraded to 1.7.4 but I do see this issue there as well but not as bad as 1.7.8 but the issue is still there... If I click on refresh then the polling gets stopped till then even though pod completes its execution pod will be still shown as running and logs keep on getting override

jessesuen commented 3 years ago

Closing as duplicate of https://github.com/argoproj/argo-cd/issues/4619