search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.94k stars 5.46k forks source link

Inconsistent sync result display after dry run #6304

Open yujunz opened 3 years ago

yujunz commented 3 years ago

Describe the bug

Dry run result are displayed in LAST SYNC RESULT but not included in HISTORY AND ROLLBACK which could confuse user.

To Reproduce

argocd app sync my-app --dry-run

Expected behavior

The display should be consistent. Either include dry run result in history or hide dry run result from app page. The latter is preferred IMHO.

Screenshots

Screen Shot 2021-05-24 at 4 32 09 PM Screen Shot 2021-05-24 at 4 32 23 PM

Version

argocd: v2.0.1+33eaf11.dirty
  BuildDate: 2021-04-21T18:44:28Z
  GitCommit: 33eaf11e3abd8c761c726e815cbb4b6af7dcb030
  GitTreeState: dirty
  GoVersion: go1.16.3
  Compiler: gc
  Platform: darwin/amd64
argocd-server: v2.0.0+9d62889
  BuildDate: 2021-04-26T12:21:07Z
  GitCommit: 9d62889f4a5a0da8da55562d4d8039cc8c9e647e
  GitTreeState: clean
  GoVersion: go1.16
  Compiler: gc
  Platform: linux/amd64
  Ksonnet Version: v0.13.1
  Kustomize Version: v4.1.2 2021-04-15T20:38:06Z
  Helm Version: v3.5.1+g32c2223
  Kubectl Version: v0.20.4
  Jsonnet Version: v0.17.0

Logs

N/A

jessesuen commented 3 years ago

HISTORY AND ROLLBACK only contains actual syncs which were successful. That will likely not change. That said, the UI could be improved to indicate the last sync was actually a dry-run.