argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.91k stars 5.46k forks source link

external-links not shown in Application if it is part of AppsOfApps #6667

Open tgruenert opened 3 years ago

tgruenert commented 3 years ago

Describe the bug

Normaly a link given by annotation link.argocd.argoproj.io/external-link should shown in app rectangle in application overview. If application is part of AppsOfApps, link is shown at umbrella application level.

To Reproduce

Given app

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: grafana
  namespace: argocd
  annotations:
    link.argocd.argoproj.io/external-link: https://mon.wolke8.it/
spec:
  project: infrastructure-common
...

and AppOfApp within startup config for argocd

    additionalApplications:
        - name: infrastructure-common
          # namespace: istio-operator
          project: infrastructure-common
          source:
            repoURL: https://github.com/XXX/common-deployments.git
            targetRevision: dev
            path: cluster/pathToAppFiles
            directory:
                recurse: true
          destination:
            server: https://kubernetes.default.svc
          syncPolicy:
            automated:
                prune: false
                selfHeal: true

Expected behavior

If annotation is for an application the link should shown for this application also at applications overview level.

Screenshots

If applicable, add screenshots to help explain your problem.

Version

v2.0.4+0842d44

pasha-codefresh commented 3 years ago

@tgruenert i can see that it is working in latest version

Снимок экрана 2021-08-02 в 12 07 52
alexef commented 2 years ago

Note that the umbrella shows all links from all resources managed. So it is expected that links are aggregated under the App of Apps Application.

This bug can be closed.

Another issue with Application links is described in #11123.