argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes

https://argo-cd.readthedocs.io

Apache License 2.0

17.65k stars 5.38k forks source link

Don't set HELM_EXPERIMENTAL_OCI environment variable #8355

Open chetan-rns opened 2 years ago

chetan-rns commented 2 years ago

Summary

Support for OCI registries is generally available in Helm v3.8.0. PR https://github.com/argoproj/argo-cd/pull/8301 upgraded the Helm version to v3.8.0 and Argo CD no longer needs to set the HELM_EXPERIMENTAL_OCI environment variable for enabling the support for OCI registries.

Proposal

Do not set the Helm experimental variable when OCI registries are being used.

shuker85 commented 2 years ago

Do we want to get rid of HELM_EXPERIMENTAL_OCI or also IsHelmOci definitions too ?