argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.71k stars 5.4k forks source link

Lighter design, please #8694

Open tebaly opened 2 years ago

tebaly commented 2 years ago

So much emphasis on the buttons is not needed.

Screenshot (4)

keithchong commented 2 years ago

Could you please elaborate:

tebaly commented 2 years ago

This is how I want to see it.

tebaly commented 2 years ago

Screenshot (7) Lighter design Emphasis on these buttons is not needed.

keithchong commented 2 years ago

I believe these were added based on the buttons on the app list page:

https://cd.apps.argoproj.io/applications?proj=&sync=&health=&namespace=&cluster=&labels=

Note also the buttons at the top in the tool bar section there (as well as the details pages) are similar looking.

I do agree with you that the buttons can have a better design.

tebaly commented 2 years ago

They don't have to be the same. The main menu can have its own design. After all, this is the main menu. The main menu should have an accent. On the secondary (tertiary) buttons, the accent is not needed and only overloads the design.

Perhaps even without borders, like on Instagram

157006805-35ff4c9c-7fa8-4fe7-954b-1046066cb163

keithchong commented 2 years ago

I agree, the main toolbar buttons do not have to look the same as the buttons in the cards.

walidshaari commented 2 years ago

I like the darker background; the lighter background lacks the focus. I guess in UX and design; it will be hard to satisfy everyone. I am very peculiar about UX and distracting or focus elements as I am not the typical neurotypical person

Kerwood commented 2 years ago

I agree with OP, to much emphasis on those buttons.

image

Kerwood commented 2 years ago

Original ArgoCD App overview image

Less emphasis image

Hover image

I am no UI master, but something like this would be nice.

Parsifal-M commented 2 years ago

Hey, I wouldn't mind picking this up as my first contribution to the project. Could you assign it to me? and perhaps point me in a general direction to where we can modify these button styles?

Thanks!

costicaaa commented 1 year ago

Hi everyone, I saw this stale issue and thought it would be a nice start, considering the label et al.

One setup later and looking into it a bit, I found a rather simple easy fix for the buttons mentioned in the latest comment.

For me, it is a clear improvement and aligned with the initial issue, of "lighter design". I'm not sure however if we should change ALL the buttons or only these ones.

I can create a PR with the initial change, only for the buttons in the Applications page view. This is a quick view of how it would like. Note: only these buttons would be affected, all the rest unchanged.

Light theme image

Light theme hover image

Dark theme image

Dark theme hover image

And for a quick glance if multiple apps present: image image

I would gladly submit a PR and start make some progress on this issue if we're ok with having a small initial PR for these buttons. Afterwards, can continue the effort if more of these should become the same (and would highly appreciate someone to help me determine which we want to change and which not).

crenshaw-dev commented 1 year ago

@costicaaa this would be great to show off in a contributors meeting! That would also be a good place to get some help from a UI reviewer.