argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.95k stars 5.46k forks source link

Only show commits with changes to path manifests only in history and rollback #9043

Closed Hax7 closed 3 months ago

Hax7 commented 2 years ago

Summary

In a monolith repository there is a lot of commits not related to the manifests path and some of these commits show up in history and rollback for an application.

Motivation

We are using a repository with both source code and manifests and that means most of the commits won't be related to the manifests but if I go to some application and click on history and rollback I would see non related commits although surprisingly not all commits(I don't know how this features decide which commit to include and which one not) which makes it confusing.

Proposal

If there is a way we can tell the application to just include commits with changes to files in path only it would be much cleaner and helpful to use this feature.

gaeljw commented 2 years ago

Note that it's considered best practice to store manifests in a different Git repository than the application source code.

Though your suggestion can still make sense as manifests repository can still contain manifests of many apps.

tribu commented 1 year ago

Also in mono git-repo with multiple manifests/services where each folder within the git-repo is a microservice's chart this will be a useful feature.

ConvoyTom commented 8 months ago

bump

crenshaw-dev commented 8 months ago

I haven't investigated deeply, but I wonder if this PR will get us this fix "for free": https://github.com/argoproj/argo-cd/pull/16295

agaudreault commented 3 months ago

@alexymantha Do you know if the history and rollback list is filtered properly when using the annotation?

alexymantha commented 3 months ago

Do you know if the history and rollback list is filtered properly when using the annotation?

It does seem to work properly with the annotation. I only see the commits that actually affected an application in the History and rollback list

agaudreault commented 3 months ago

@Hax7 feel free to reopen if this is happening on version >2.11.0