argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.89k stars 5.46k forks source link

ArgoCD doesn't show diff for suspended CronJob #9129

Open NickLarsenNZ opened 2 years ago

NickLarsenNZ commented 2 years ago

Checklist:

Describe the bug

During a migration, we disabled sync and suspended a number of CronJobs. After enabling sync (and running a manual sync), the CronJobs are still suspended and there is apparently no diff even though I can see it

To Reproduce

  1. Create CronJob (without the spec.suspend key
  2. Disable Auto-Sync in ArgoCD for the application
  3. Suspend the CronJob spec.suspend: true
  4. Enable Auto-Sync in ArgoCD (or manually Sync)
  5. Observe that the CronJob still shows successful sync, but spec.suspend: true still appears in the Live Manifest view.

Expected behavior

I expect the manifest to sync with the git repository (for spec.suspend: false or nothing to appear).

Screenshots

Version

I'm using an older version of ArgoCD due to oAuth issues - perhaps those are resolved and I can upgrade now.

argocd: v2.2.3+987f665
  BuildDate: 2022-01-18T17:53:49Z
  GitCommit: 987f6659b88e656a8f6f8feef87f4dd467d53c44
  GitTreeState: clean
  GoVersion: go1.16.11
  Compiler: gc
  Platform: linux/amd64
FATA[0000] Argo CD server address unspecified

Logs

N/A

alixinne commented 2 years ago

The issue is present on v2.3.3+07ac038 as well. I am not using AutoSync, but editing the CronJob's suspend field never shows any diff (and Sync has no effect). (Hard) Refreshing does not change anything.

andrii-shevchyk commented 2 years ago

The same story with volumes/volumeMounts, you can change those fields manually and ArgoCD won't notice that.

shay-berman commented 1 year ago

Also here

minh-gfg commented 1 year ago

Interesting, from my side ArgoCD does not show diff for serviceAccount

fredleger commented 11 months ago

Same in argocd 2.6.0

PrayagS commented 10 months ago

+1 for ArgoCD (v2.4.14) not recognizing suspend: true and nodeSelector/tolerations changes in the diff.

CC: @Shrilekh

gnarroway-bullish commented 4 months ago

Created a new CronJob with suspend: true, and it got synced with suspend: false, which is a bit alarming.

v2.11.2+25f7504

henryzhao95 commented 3 months ago

Seeing the same as @gnarroway-bullish with v2.9.5+f943664 where:

nerzhul commented 1 month ago

we noticed also the same issue, if we edit a cronjob to set suspend: true from argocd UI there is no diff shown in UI then we cannot remind at a point that the cronjob was suspended