argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.63k stars 5.37k forks source link

task: Update Dockerhub to point to Quay #9244

Open todaywasawesome opened 2 years ago

todaywasawesome commented 2 years ago

Summary

Argo CD on Dockerhub doesn't show any notice that this repo is not used any longer. It should reference the new home for images at https://quay.io/repository/argoproj/argocd?tab=tags

Motivation

Stumbling on Dockerhub, users might get lost and think that is the correct place to pull images from.

Proposal

Add a notice to the top of the page.

Deprecation Notice: Argo Project has moved image hosting to Quay. You can find official images here, and releases are available in Github.

good92 commented 1 year ago

But quay seems non free: https://quay.io/plans/

crenshaw-dev commented 1 year ago

@good92 I believe Red Hat lets Argoproj use it for free. Or maybe there's an arrangement via CNCF. At any rate, I'm pretty sure we don't pay to host our images on Quay.

good92 commented 1 year ago

@crenshaw-dev Thanks, I now understand better why quay.io is used at https://github.com/crenshaw-dev/argo-cd/blob/d8642fd95108673d7dcdbd9147eb5d9d41471150/docs/proposals/config-management-plugin-v2.md

I am trying to fix msg="read /home/argocd/cmp-server/config/plugin.yaml: is a directory" when using argocd-vault-plugin with argocd 2.7.3 with its HC 5.34.6

crenshaw-dev commented 1 year ago

@good92 can you open a new issue and include the sidecar manifest? Looks like maybe the ConfigMap volume mount is incorrect.

good92 commented 1 year ago

Quay.io pulling does not work for me:

stream logs failed container "argocd-cmp-server-copy" in pod "argocd-repo-server-7f598b59d4-hc9rv" is waiting to start: trying and failing to pull image for argocd/argocd-repo-server-7f598b59d4-hc9rv (argocd-cmp-server-copy)

context:

NAME↑                    PF  IMAGE                             READY    STATE               INIT       RESTARTS PROBES(L:R)     CPU   MEM   CPU/R:L   MEM/R:L   %CPU/R   %CPU/L   %MEM/R   %MEM/L PORTS                            AGE     │
│ argocd-cmp-server-copy   ●   quay.io/argoproj/argocd:2.7.3     false    ImagePullBackOff    true              0 off:off           0     0       0:0       0:0      n/a      n/a      n/a      n/a                                  33m     │
│ copyutil                 ●   quay.io/argoproj/argocd:v2.7.3    true     Completed           true              0 off:off           0     0       0:0       0:0      n/a      n/a      n/a      n/a                                  33m     │
│ download-vault-plugin    ●   alpine:3.8                        false    PodInitializing     true              0 off:off           0     0       0:0       0:0      n/a      n/a      n/a      n/a                                  33m     │
│ repo-server              ●   quay.io/argoproj/argocd:v2.7.3    false    PodInitializing     false             0 on:on             0     0       0:0       0:0      n/a      n/a      n/a      n/a repo-server:8081,metrics:8084    33m     │
│ vault                    ●   alpine/helm                       false    PodInitializing     false             0 off:off           0     0       0:0       0:0      n/a      n/a      n/a      n/a      
crenshaw-dev commented 1 year ago

Looks like the tag on argocd-cmp-server-copy needs a v before 2.7.3.

good92 commented 1 year ago

many thanks that was it, it works better now.

 NAME↑                    PF  IMAGE                            READY   STATE               INIT       RESTARTS PROBES(L:R)     CPU   MEM   CPU/R:L   MEM/R:L   %CPU/R   %CPU/L   %MEM/R   %MEM/L PORTS                            AGE       │
│ argocd-cmp-server-copy   ●   quay.io/argoproj/argocd:v2.7.3   true    Completed           true              0 off:off           0     0       0:0       0:0      n/a      n/a      n/a      n/a                                  8m44s     │
│ copyutil                 ●   quay.io/argoproj/argocd:v2.7.3   true    Completed           true              0 off:off           0     0       0:0       0:0      n/a      n/a      n/a      n/a                                  8m44s     │
│ download-vault-plugin    ●   alpine:3.8                       true    Completed           true              0 off:off           0     0       0:0       0:0      n/a      n/a      n/a      n/a                                  8m44s     │
│ repo-server              ●   quay.io/argoproj/argocd:v2.7.3   true    Running             false             0 on:on             1    20       0:0       0:0      n/a      n/a      n/a      n/a repo-server:8081,metrics:8084    8m44s     │
│ vault                    ●   alpine/helm                      false   CrashLoopBackOff    false             6 off:off           0     0       0:0       0:0      n/a      n/a      n/a      n/a                                  8m44s     │

gtirloni commented 8 months ago

I spent some time looking for newer images in Docker Hub and learned ArgoCD moved to Quay.io today.

I would appreciate a warning in Docker Hub, if possible.

GregdTd commented 5 months ago

Same here until I found this issue :)