search

argoproj / argo-events

Event-driven Automation Framework for Kubernetes
https://argoproj.github.io/argo-events/
Apache License 2.0
2.38k stars 740 forks source link

Sensors are coupled to EventSourceNames #1016

Open paveq opened 3 years ago

paveq commented 3 years ago

Currently sensors are required to specify eventSourceName, in addition to events they are interested.

Expected behavior It is enough to specify only event name.

As example: there is event named "alert", and alerts can come from various systems, and sensor processes these (eg. workflow that sends email). Each time new alert generating system is added, sensor needs to be modified.

whynowy commented 3 years ago

This is an interesting suggestion, allowing one of eventSourceName and eventName optional. Thoughts? @VaibhavPage

paveq commented 3 years ago

Could add, that currently it is possible to create a sensor without eventSourceName, but it won't receive any events. This can be bit confusing.

whynowy commented 3 years ago

Could add, that currently it is possible to create a sensor without eventSourceName, but it won't receive any events. This can be bit confusing.

Now it expects both present, somehow there's not a validation in place.

vfarcic commented 3 years ago

+1

natalie-elizabeth commented 3 years ago

+1

VaibhavPage commented 3 years ago

@whynowy how is the topic name constructed for eventbus?

zoftdev commented 3 years ago

+1