search

argoproj / argo-events

Event-driven Automation Framework for Kubernetes
https://argoproj.github.io/argo-events/
Apache License 2.0
2.34k stars 730 forks source link

Support returning payload response in Webhook EventSource #2776

Open yaariyuval opened 1 year ago

yaariyuval commented 1 year ago

Is your feature request related to a problem? Please describe. I've implemented a webhook EventSource. I'd like to return the event ID as part of the response, so that the caller would be able to keep track of the workflow that gets triggered. Ideally, it should also be possible to return a link to the Argo Workflow dashboard, if possible.

Describe the solution you'd like Allow returning information as part of the webhook response. The Cloud Events spec doesn't specifically touch on this, it only says: "The delivery response MAY contain a payload providing detail status information in the case of handling errors. This specification does not attempt to define such a payload."

Describe alternatives you've considered I've considered implementing a custom EventSource.

Additional context N/A

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

MakeItSkip commented 2 months ago

This would definitely be a great feature.

I have currently solved this by sending a unique ID as part of the payload and add it as a label. Then, I provide a link which filters the workflows to the label with their unique ID that they supplied.