search

argoproj / argo-events

Event-driven Automation Framework for Kubernetes
https://argoproj.github.io/argo-events/
Apache License 2.0
2.37k stars 738 forks source link

Only allowing EventBus to be from jetstream #2905

Closed alexlatchford closed 9 months ago

alexlatchford commented 11 months ago

Describe the bug A clear and concise description of what the bug is.

We'd like to lock down Argo Events EventBus to just allow clients to use jetstream but the ValidateConfig method enforces at least one version of each here.

To Reproduce Steps to reproduce the behavior:

  1. Update the argo-events-controller-config ConfigMap to remove the eventBus.nats.versions array.
  2. Redeploy the controller-manager, keep some items in the eventBus.jetstream.versions array.
  3. See error no stan versions were provided in the controller config in the controller-manager pod logs.

Expected behavior A clear and concise description of what you expected to happen.

No error, should be possible to not give the option to run nats as the EventBus.

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Add any other context about the problem here.

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. It will be closed if no further activity occurs. Thank you for your contributions.