search

argoproj / argo-events

Event-driven Automation Framework for Kubernetes
https://argoproj.github.io/argo-events/
Apache License 2.0
2.37k stars 738 forks source link

jetstreamExotic requiring secure connection (no opt-out) #2938

Open diogobaeder opened 11 months ago

diogobaeder commented 11 months ago

Describe the bug Argo Events requires secure connection to use jetstreamExotic, but it shouldn't - not because secure connections shouldn't be used, but because there are cases when they're not required, like on dev environments (which is my case) and when running inside a service mesh that provides mTLS.

To Reproduce Steps to reproduce the behavior:

  1. Run a NATS server with JetStream enabled, but without any secure connections enabled
  2. Spin up Argo Events
  3. Create an EventBus pointing to the NATS server, using jetstreamExotic
  4. Check the logs

Expected behavior I should be able to connect the EventBus with the external NATS server without problems.

Screenshots (None)

Environment (please complete the following information):

Additional context Here's where the secure connection is forced: https://github.com/argoproj/argo-events/blob/master/eventbus/jetstream/base/jetstream.go#L70

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

ondrejmo commented 7 months ago

Is there any plan to fix this? I am asking mostly because it seems to me that the argo-events is no longer being actively developed and it would be good to know if I should search for replacement. Thank you

diogobaeder commented 7 months ago

Yeah, it looks like it's not very active at the moment. I don't know if this has anything to do with Octopus buying Codefresh, but I sure hope the project gets some love again.

For the time being, though, I was forced to stop using it.