search

argoproj / argo-events

Event-driven Automation Framework for Kubernetes
https://argoproj.github.io/argo-events/
Apache License 2.0
2.34k stars 730 forks source link

EventSource/WebHook - Service annotations #3242

Open pburgisser opened 1 month ago

pburgisser commented 1 month ago

Is your feature request related to a problem? Please describe. On GKE with Application LoadBalancer, when exposing a webhook a HTTP healthcheck is automatically created and points to the service port (for example 12000) on path /. The checks fail as the probe is on /health. We can override the path to user by creating a backendconfig. However, we need to reference that backendconfig in the service's annotations.

Documentation of the EventSource shows that we can't inject custom annotations

Describe the solution you'd like In the service's part of the EventSource, we should be able to add annotations.

Describe alternatives you've considered Creating (and "duplicating") a service that points to the webhook pod with the annotations

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

MenD32 commented 3 weeks ago

I have also experienced this issue, a quick fix is to define the BackendConfig in the GCP console but it'd be very nice to have it work out-of-the-box in k8s

MenD32 commented 3 weeks ago

i opened a PR since this change can be pretty easy to implement