search

argoproj / argo-helm

ArgoProj Helm Charts
https://argoproj.github.io/argo-helm/
Apache License 2.0
1.78k stars 1.88k forks source link

argo-rollouts: allow custom spec.strategy for the apps/ve #1666

Closed dsaintilma-flinks closed 1 year ago

dsaintilma-flinks commented 2 years ago

Is your feature request related to a problem?

Restarting the deployment recreates all the replicas. Pulling metrics is not possible while the recreation of pods in on-going.

Related helm chart

argo-rollouts

Describe the solution you'd like

I would like to be able to use rollingUpdate instead with the ability to setup maxSurge & maxUnavailable parameters so that the pods would be replaced one after the other.

Describe alternatives you've considered

No response

Additional context

No response

mkilchhofer commented 2 years ago

@huikang does this it make sense? This would require leader election but what happens when the leader goes down, does the other pod serves the metrics?

I ask you as you implemented leader election for rollouts here: https://github.com/argoproj/argo-rollouts/pull/1519

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.