search

argoproj / argo-helm

ArgoProj Helm Charts
https://argoproj.github.io/argo-helm/
Apache License 2.0
1.69k stars 1.84k forks source link

full changelog diff on releases is wrong #2796

Open wmcnamee-coreweave opened 2 months ago

wmcnamee-coreweave commented 2 months ago

Describe the bug

This release shows this link: Full Changelog: https://github.com/argoproj/argo-helm/compare/argocd-image-updater-0.10.1...argo-cd-7.0.0

The real diff is this: https://github.com/argoproj/argo-helm/compare/argo-cd-6.11.1...argo-cd-7.0.0

which to be honest, doesn't really make much sense. I'd expect to see argcd-6.11.1...argo-cd-7.0.0. This seems to apply across all charts in this monorepo. :(

Related helm chart

argo-cd, argo-events, argo-rollouts, argo-workflows, argocd-image-updater, argocd-apps

Helm chart version

7.0.0

To Reproduce

go to https://github.com/argoproj/argo-helm/releases/tag/argo-cd-7.0.0

Expected behavior

the changelog points to current and previous tags for the relevant chart.

Screenshots

image

Additional context

No response

agilgur5 commented 2 months ago

It's using GH's generated changelog via chart-releaser. The changelog diff does not seem configurable, so I guess this is on GH interpreting tag order incorrectly. Might be not handling monorepos well?

Probably worth a GH support ticket cc @yu-croco @mkilchhofer @jmeridth

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.