Closed bensoer closed 1 month ago
The quick-fix around, to be able to unblock deploying multiple is to deploy each Argo Workflow with a unique release name. This then causes the ClusterRole name to be generated containing those unique release names and thus not name clashing
But, from my understanding, running with singleNamespace=true
should be creating Role
s, not ClusterRole
s ?
Describe the bug
See Helm Template: https://github.com/argoproj/argo-helm/blob/main/charts/argo-workflows/templates/controller/workflow-controller-cluster-roles.yaml#L204
The role here does not contain the
singleNamespace
check as done here: https://github.com/argoproj/argo-helm/blob/main/charts/argo-workflows/templates/controller/workflow-controller-cluster-roles.yaml#L3This causes a clashing when deploying 2 Argo Workflows in the same cluster, with
singleNamespace
enabled, and in seperate namespacesWhen deploying in Terraform the error comes out as:
Related helm chart
argo-workflows
Helm chart version
Found in 0.42.1 . Can see issue also Helm in 0.42.3
To Reproduce
See Helm Template: https://github.com/argoproj/argo-helm/blob/main/charts/argo-workflows/templates/controller/workflow-controller-cluster-roles.yaml#L204
Reproduction can be done by deploying argo workflows helm twice onto the same cluster:
Note: This setup assumes the argo helm repo is already setup in your helm under the alias of
argo
Deploy the first one:
Note:
crds.install=true
is explicite, the second install has it set tofalse
. This avoids CRD conflictsDeploy the second one:
The second deployment will fail with a clash on the ClusteRole name conflict - eventhough were in
namespaced
modeExpected behavior
General behavior is that when deploying Argo Workflows in namespaced mode, it should only be creating
Role
objects, notClusterRole
objects - https://argo-workflows.readthedocs.io/en/latest/managed-namespace/Screenshots
No response
Additional context
No response