search

argoproj / argo-helm

ArgoProj Helm Charts
https://argoproj.github.io/argo-helm/
Apache License 2.0
1.77k stars 1.88k forks source link

ArgoCD Helm: Impossible to get a PDB for redis-ha #3007

Closed mruoss closed 3 weeks ago

mruoss commented 3 weeks ago

Describe the bug

Currently in the ArgoCD redis/pdb helm template, there's logic that prevents the PDB to be created if redis-ha is enabled. This doesn't make sense, right? I'd even argue that PDB for HA is necessary?

Related helm chart

argo-cd

Helm chart version

7.6.12

To Reproduce

use the following values when deploying:

redis-ha:
  enabled: true
redis:
  pdb:
    enabled: true
    minAvailable: 1

Expected behavior

this should create a PDB resource

Screenshots

No response

Additional context

No response

mruoss commented 3 weeks ago

Never mind! redis-ha uses a dependency so I guess the values for it need to be configured under .redis-ha.