search

argoproj / argo-helm

ArgoProj Helm Charts
https://argoproj.github.io/argo-helm/
Apache License 2.0
1.77k stars 1.88k forks source link

Remove Capabilities.APIVersions for Kustomize to parse file #3013

Open 0xDones opened 1 week ago

0xDones commented 1 week ago

Is your feature request related to a problem?

Deploying the Helm Chart using Kustomize (kubectl kustomize . --enable-helm) won't deploy resources that have these kind of check, for example the ServiceMonitors.

Related helm chart

argo-cd

Describe the solution you'd like

Remove the api version checks from the ServiceMonitors and any other resource.

Describe alternatives you've considered

No response

Additional context

For reference, this issue on ingress-nginx Chart describes the exactly same issue: https://github.com/kubernetes/ingress-nginx/pull/7829

mkilchhofer commented 1 week ago

Did you read our statement about this?

See: https://github.com/argoproj/argo-helm?tab=readme-ov-file#charts-use-helm-capabilities

0xDones commented 1 week ago

I did after opening the issue, it solved the problem but still feels like "hack" solution. I'm still not sure if there is a lot of advantages of using this check since there are still 2 other flags that need to be set to true before deploying the ServiceMonitors: metrics.enabled=true and metrics.serviceMonitor.enabled=true.