search

argoproj / argo-helm

ArgoProj Helm Charts
https://argoproj.github.io/argo-helm/
Apache License 2.0
1.76k stars 1.88k forks source link

dex-server and notifications controller hard coded replicas #3022

Open kirrmann opened 2 days ago

kirrmann commented 2 days ago

Describe the bug

Both the deployments have a hard coded replicas: 1, which is surprising because for both a PDB can be setup. Is there any reason for setting this fixed values and not exposing it in values.yaml?

Related helm chart

argo-cd

Helm chart version

7.7.1

To Reproduce

See dex deployment template and notifications-controller deployment-template to see that replicas is hard coded to 1

Expected behavior

notifications.replicas and dex.replicas should be exposed as a setting in values.yaml

Screenshots

No response

Additional context

No response

kirrmann commented 2 days ago

If this is not intended then I can create a Pull Request

mkilchhofer commented 1 day ago

Re: Dex

Dex is intended and also the background is documented:

The argocd-dex-server uses an in-memory database, and two or more instances would have inconsistent data.

Source: https://argo-cd.readthedocs.io/en/stable/operator-manual/high_availability/#argocd-dex-server-argocd-redis

Re: Notification controller

There are various issues upstream when running more than one replica, e.g.: