argoproj / argo-rollouts

Progressive Delivery for Kubernetes
https://argo-rollouts.readthedocs.io/
Apache License 2.0
2.79k stars 874 forks source link

kubectl-argo-rollouts-linux-amd64 get rollout -w; exit when finished #1172

Open DanTulovsky opened 3 years ago

DanTulovsky commented 3 years ago

Summary

Would it be possible make mimic the behavior of:

kubectl rollout status

It blocks while the rollout is progressing, and exits when it's done.

kubectl-argo-rollouts-linux-amd64 get rollout -w

currently does not exit when a rollout is finished.

Use Cases

The use case is in automation pipelines. After doing a helm upgrade it watches the rollout and updates the logs (for any humans watching). Once the rollout finishes, kubectl-argo-rollouts-linux-amd64 should exit, allowing the pipeline to complete.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

DanTulovsky commented 3 years ago

Nevermind, I see:

# Watch the rollout until it succeeds, fail if it takes more than 60 seconds
kubectl argo rollouts status --timeout 60 guestbook
DanTulovsky commented 3 years ago

Actually, would it be possible for status to output the same thing as get rollout does? That way you can watch the rollout progress, and then the command exists when done.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity.