I wouldn't necessarily call this a bug or an enhancement, but it does seem like there are docs missing for a change made in September of 2022 around traffic routing for ALB.
The PR below shows that this code was implemented and continues to be in place today, but the documentation (both in the specification.md and traffic-management/index.md) states that Istio is the only supported ingress controller for Traffic router support.
If I'm seeing this correctly, would the docs be fixed with a simple addition to include ALB in the supported controllers? Or are there caveats worth mentioning to the implementation with ALB compared to Istio?
If I'm not seeing this correctly, and the docs are right with Istio being the only supported controller for header based routing, is this code dormant and awaiting some further contribution before it can be used?
Use Cases
We already do something similar today to modify the ingress during a deployment to separately route requests with a given header to a preview service for blue green, but if this is indeed supported - we could adopt canary instead.
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
Summary
I wouldn't necessarily call this a bug or an enhancement, but it does seem like there are docs missing for a change made in September of 2022 around traffic routing for ALB. The PR below shows that this code was implemented and continues to be in place today, but the documentation (both in the specification.md and traffic-management/index.md) states that Istio is the only supported ingress controller for Traffic router support.
https://github.com/argoproj/argo-rollouts/pull/2214
I also see the following related issue and comments that this was closed and implemented: https://github.com/argoproj/argo-rollouts/issues/2086
@zachaller for visibility
If I'm seeing this correctly, would the docs be fixed with a simple addition to include ALB in the supported controllers? Or are there caveats worth mentioning to the implementation with ALB compared to Istio?
If I'm not seeing this correctly, and the docs are right with Istio being the only supported controller for header based routing, is this code dormant and awaiting some further contribution before it can be used?
Use Cases
We already do something similar today to modify the ingress during a deployment to separately route requests with a given header to a preview service for blue green, but if this is indeed supported - we could adopt canary instead.
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.