search

argoproj / argo-rollouts

Progressive Delivery for Kubernetes
https://argo-rollouts.readthedocs.io/
Apache License 2.0
2.61k stars 819 forks source link

Show logs or link to Job Analysis logs in the dashboard #3054

Open danil-smirnov opened 10 months ago

danil-smirnov commented 10 months ago

Summary

When Analysis is run via a Job, logs of the run should be exposed in the dashboard. Alternatively, it could be a link, that is retrieved by the job. Or, at least, it could be a link defined in the Analysis Template statically.

Use Cases

We trigger our Testkube tests via an Analysis - Job provider. We want to have easy access to the failed tests report via a link or directly in the dashboard. We output that report as our job's logs.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

zachaller commented 10 months ago

This is a very non-trivial thing to add as was brought up here, https://github.com/argoproj/argo-rollouts/issues/2482 this actually also led to one of many reasons that we enabled plugin support, I am not sure what you are doing in your job but it could be more productive to possibly do it as a plugin as well

danil-smirnov commented 10 months ago

@zachaller Is plugin from https://github.com/argoproj/argo-rollouts/issues/2482 publicly available? I'm not sure...

Did you consider showing more information for Analysis in the dashboard than just the name?

It would be great if we can click and see metric evaluation result right in the UI - isn't this the UI has been built for?

And for the Analysis Job type it can be logs of the job pod...

zachaller commented 10 months ago

Sorry, I see you just want the pod logs that seems reasonable. I was thinking you possibly wanted to return a link from the output of a job. In this case just showing the logs of the pods I think is an easier ask

danil-smirnov commented 10 months ago

Yes, and minimal solution would be just to set an optional static link in the job analysis template and show this link as a "See more" button in the UI.

We can point that link to the particular test page in Testkube to make both things connected.

More advanced impovement would be to show logs of the job pod since we can stream the test results into there via a Testkube API call.

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 60 days with no activity.

utsheth-te commented 6 months ago

Are there any updates on this? Maybe a workaround that will not require the use of a plugin?