argoproj / argo-rollouts

Progressive Delivery for Kubernetes
https://argo-rollouts.readthedocs.io/
Apache License 2.0
2.67k stars 839 forks source link

Support Linkerd as traffic provider #3387

Open amcamina opened 6 months ago

amcamina commented 6 months ago

Summary

In our environment, the service mesh used is linkerd. Linkerd is not officially supported by Argo Rollouts. However, Linkerd provided a way to use Argo Rollouts with it. I added a link below.

What change needs making?

The minimal change that I suggest is to add a key in values to add your rules in ClusterRole resource called argo-controller-role (link)

The lines that I would add to the (file) would be:

{{- if .Values.providerRBAC.providers.linkerd }}
  # Access needed when using the Linkerd provider
  - apiGroups:
      - gateway.networking.k8s.io
    resources:
      - httproutes
    verbs:
      - "*"
{{- end }}

Reference

Use Cases

Use Argo Rollouts with Linkerd


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

zachaller commented 6 months ago

So rollouts has taken the stance the the plugin author will maitain the proper RBAC for their usage. The heml project within argoproj though could decide to maintain the RBAC rules via a values config like you suggest I would move this ticket to https://github.com/argoproj/argo-helm