search

argoproj / argo-rollouts

Progressive Delivery for Kubernetes
https://argo-rollouts.readthedocs.io/
Apache License 2.0
2.75k stars 865 forks source link

status.observedGeneration field violates type convention #3402

Open isugimpy opened 7 months ago

isugimpy commented 7 months ago

Checklist:

Describe the bug

Interactions with the status.observedGeneration field on Rollouts behave unexpectedly because the field is forced to be a string rather than an integer on the CRD. This leads to incompatibilities with tooling which observe that field to ensure state of an object. This is particularly frustrating when trying to use Rollouts resources with FluxCD.

To Reproduce

  1. Create a Rollout
  2. Get the Rollout from the API
  3. Observe that the value of status.observedGeneration is in quotes

Expected behavior

The status.observedGeneration field should be an integer in the CRD and represented internally in the controller code as an int64, matching convention of upstream.

Screenshots

N/A

Version

1.6.6

Logs

No relevant logs.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

gecube commented 1 week ago

I am asking to fix it, almost the half a year passed - no motion and another colleague was hit by this bug:

https://cloud-native.slack.com/archives/CLAJ40HV3/p1728910929113889