Open MohammedShetaya opened 4 months ago
@zachaller any update on this issue?
@MohammedShetaya According to this issue https://github.com/argoproj/argo-rollouts/issues/2250 some people might prefer the result of the analysis to be inconclusive if there is an image pull error.
Would you agree with this implementation?
@kostis-codefresh It should stay inconclusive then, in our case it considers the inconclusive state as success and proceeds with the rollout. This allows the canary deployment to go unchecked.
Also see discussion at https://github.com/argoproj/argo-rollouts/issues/1329
I think if Jobs supported successConditions you could maybe feed successConditions the output of a few things like pod exits codes and pod errors that could get used to define a success condition. This support would need to be added I think though.
I think if Jobs supported successConditions you could maybe feed successConditions the output of a few things like pod exits codes and pod errors that could get used to define a success condition. This support would need to be added I think though.
Exactly, I tried to do it assuming jobs, like other metrics, support successConditions, but it didn't work.
Checklist:
Describe the bug
Analysis Run of type job never fails when the job image can't be pulled (it just succeeds and promotes). When Job pods can't pull image it goes into
ErrImagePull
indefinitely and the job itself does not Fail. However, Argo rollouts waits for some time and considers this as success and then promotes the canary.To Reproduce
test-namespace
nginx:1.19.0
to trigger a rolloutExpected behavior
ErrImagePull
. It will also delete both the job and the rollout from the cluster.Screenshots
Version Tested on v1.6.6 and previous versions.
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.