search

argoproj / argo-rollouts

Progressive Delivery for Kubernetes
https://argo-rollouts.readthedocs.io/
Apache License 2.0
2.8k stars 876 forks source link

Better status indicators for Pods in UI #3609

Open DanTulovsky opened 6 months ago

DanTulovsky commented 6 months ago

Summary

It would be helpful if the status indicators for pods during a rollout (e.g. these)

image

were more fine grained. Specifically, they should take into account the readiness state of the app itself.

We had an issue where a rollout started, and new pods came up. They were scheduled and live, as far as k8s was concerned, but they were not yet ready according to the readiness configuration. Regardless though, the UI showed the pods as green and operators (incorrectly) assumed that everything was fine. This status, combined with the fact that Argo Rollouts frequently gets stuck, led the human operators to draw the wrong conclusion (they assumed argo rollouts was stuck) and they did a full promote. For various, here unimportant, reasons, that caused an outage.

Perhaps the UI can take into account all the possible states for a pod (https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/) and expose them to the users.

Use Cases

All the time.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

rafaeljesus commented 5 months ago

AFAICS, this was addressed in https://github.com/argoproj/argo-rollouts/pull/3483