argoproj / argo-rollouts

Progressive Delivery for Kubernetes
https://argo-rollouts.readthedocs.io/
Apache License 2.0
2.77k stars 867 forks source link

Support gloo #620

Closed snuggie12 closed 1 year ago

snuggie12 commented 4 years ago

We're very interested in using rollouts and use gloo as our gateway and istio as our service mesh. It seems like istio will work for all services within the mesh.

Could gloo be added to the support list as a gateway handling north/south traffic?

jessesuen commented 4 years ago

We don't have much gloo experience but Rollouts manages VirtualServices, so if gloo is pointing to the VirtualService, in theory your use case might be already supported, unless you are asking for a gloo specific integration.

snuggie12 commented 4 years ago

I read on the website if something wasn't supported to request it. However, I think the istio VirtualService (gloo also has a resource called that,) with gateway set to mesh might work. It might not though because gloo has no sidecar for outbound traffic, but rather is running envoy and can use the same mtls certs.

In the next couple of weeks I'll give it a shot, but in the meantime I wanted to make the request for official support.

snuggie12 commented 3 years ago

After reading over rollouts and istio more this will definitely work for any services for east/west traffic, but any north/south traffic that goes through gloo will not work.

So this would be requesting that gloo gets added to the list as a standalone api gateway probably most similar to the nginx IC.

lowkeyliesmyth commented 3 years ago

I would definitely be interested in this feature too. Functionally the integration should be similar to that of the Ambassador integration.

kostis-codefresh commented 3 years ago

It seems that Gloo will have an implementation for the Kubernetes Gateway API https://gateway-api.sigs.k8s.io/implementations/#gloo-edge

So Gloo support might be available after implementing #1438

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity.

kostis-codefresh commented 1 year ago

The first version of the Gateway API plugin is out

https://github.com/argoproj-labs/rollouts-gatewayapi-trafficrouter-plugin

zachaller commented 1 year ago

This will also probably be coming closing due to the two options: https://github.com/argoproj/argo-rollouts/issues/2876

kostis-codefresh commented 12 months ago

Supported via the API gateway https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/tree/main/examples/gloo-gateway

There is also a native plugin as well https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-glooplatform