Update Node.js version on CI

[sosukesuzuki]

context: https://github.com/argoproj/argo-ui/pull/265#issuecomment-1684181071

• Make it refer .nvmrc from GitHub Actions workflows
• Update Node.js version from 14.15 to 18.17 because 18.x is current LTS version

[github-actions[bot]]

Stale pull request message

[agilgur5]

context: #265 (comment)

Hey sorry, I totally didn't see this PR; thought you would make the change in that PR. This works too, just that #265 will need rebasing after this

• Update Node.js version from 14.15 to 18.17 because 18.x is current LTS version

This is good to have, just will have to make sure nothing else breaks from the more significant upgrade

[agilgur5]

It looks like the build step never ran for some reason 😕

@terrytangyuan are you able to merge master into this PR so that the checks (hopefully) run?

[terrytangyuan]

triggered

[agilgur5]

Thanks Terry! The build ran this time, but failed due to the infamous digital envelope routines::unsupported OpenSSL version error. I'll work on that offline and submit a superseding PR

[agilgur5]

So we could use the OpenSSL legacy provider to workaround the issue, as we did in https://github.com/argoproj/argo-workflows/pull/11410 and https://github.com/argoproj/argo-workflows/pull/11461, but I'd prefer to just update the deps so we don't have the OpenSSL vuln anyway (although it only impacts local dev, so not a huge deal).

Unfortunately, the main dep that needs upgrading for that is Webpack, which is only used by Storybook in this repo. The problem there is that we're on an old version of Storybook, v6, which hasn't been updated since 2022. Upgrading to Storybook v7 is fairly non-trivial, not the least of which because there are actually three Storybook builds in this repo: for v1, v2, and antd (also there's a separate yarn.lock for v2 for some reason, which I imagine might've been an accident, but idk -- EDIT: See #510 regarding the second yarn.lock, it is extraneous/no longer used). The main two active builds have two different configurations as well, and heck even configuration files themselves, with v1's being 6+ years old and still using Storybook v5 syntax etc.

I tried updating the deps and everything to at least get v2 working, but kept getting build error after build error fixing one-by-one. So this may very well not be worth upgrading given the current state of the repo per #453.

Sooo I might just enable the OpenSSL legacy provider workaround instead and at least get Node updated to non-EoL (Storybook et al will have to come later I guess 😕 (if ever))

[agilgur5]

node-version-file was specified in #509, and Node upgrade to v20 is completed in #536

[github-actions[bot]]

Stale pull request message