search

argoproj / argo-ui

Argoproj shared React components
Apache License 2.0
222 stars 179 forks source link

chore(deps): bump `react-router-dom` from 4.3.1 to 6.20.0 #481

Closed sunyeongchoi closed 7 months ago

sunyeongchoi commented 10 months ago

https://github.com/argoproj/argo-ui/pull/480

dependabot automatically updates the react-router-dom version, but as the version is upgraded 6, the functions used change, causing errors in the build.

So, I changed it to use a function that matches the react-router-dom 16 version.

agilgur5 commented 9 months ago

Note that this a (very) breaking change, so it does affect all downstream UI builds as well which we have to be fairly careful with.

I took care of the last remaining react-router v4 piece in Workflows in https://github.com/argoproj/argo-workflows/pull/11891. I haven't checked all v5 to v6 breaking changes yet though. We'd also probably want to upgrade to v5.1 first, per the upgrade guide

Also not sure if CD is able to upgrade. If not possible yet, they'd have to stay on the version before this gets merged.

github-actions[bot] commented 7 months ago

Stale pull request message