Closed agilgur5 closed 8 months ago
Fixes #264 Supersedes #265 and #428, as well as part of #432 (the node-version-file part in the GH Actions) Closes #265, Closes #428
node-version-file
Credit very much given to the original author of those who put in most of the legwork @sosukesuzuki, I am just updating it to get it to pass CI etc
tslint
eslint
@typescript-eslint
Config partly mostly double-checked against other tslint -> eslint migrations I've worked on recently: https://github.com/argoproj/argo-workflows/pull/12163 and https://github.com/ezolenko/rollup-plugin-typescript2/pull/463
overrides
lint
tslint-react
tslint.json
.eslintrc.json
@typescript-eslint/no-explicit-any
@typescript-eslint/no-non-null-assertion
tslint:disable-next-line
eslint-disable-next-line
remove unused jshintrc
jshintrc
fix various lint errors
{}
any
UNSAFE_
upgrade Node version to latest v14 so that install & CI passes with current versions of deps (they require newer Node)
CI passes
Fixes #264 Supersedes #265 and #428, as well as part of #432 (the
node-version-file
part in the GH Actions) Closes #265, Closes #428Credit very much given to the original author of those who put in most of the legwork @sosukesuzuki, I am just updating it to get it to pass CI etc
Motivation
tslint
had been officially deprecated in favor ofeslint
with@typescript-eslint
since at least early 2019Config partly mostly double-checked against other
tslint
->eslint
migrations I've worked on recently: https://github.com/argoproj/argo-workflows/pull/12163 and https://github.com/ezolenko/rollup-plugin-typescript2/pull/463overrides
, but it did LGTM in code review of #265. Per https://github.com/argoproj/argo-ui/pull/265#pullrequestreview-1581209971, can make further changes as needed after this PR is mergedModifications
Migration changes
lint
script to useeslint
tslint
&tslint-react
to theireslint
/@typescript-eslint
counterpartstslint.json
to.eslintrc.json
@typescript-eslint/no-explicit-any
and@typescript-eslint/no-non-null-assertion
tslint:disable-next-line
comment toeslint-disable-next-line
commentOther necessary or related changes
remove unused
jshintrc
fix various lint errors
{}
->any
or a more specific typeUNSAFE_
prefix to deprecated React methodsupgrade Node version to latest v14 so that install & CI passes with current versions of deps (they require newer Node)
Verification
CI passes