search

argoproj / argo-ui

Argoproj shared React components
Apache License 2.0
220 stars 178 forks source link

feat: #17436 Update dropdown-menu.tsx to have standard link behaviour #544

Closed Hussain-Ruhullah closed 2 months ago

Hussain-Ruhullah commented 6 months ago

Closes [ISSUE #17436] Screenshot 2024-03-07 130000

Hussain-Ruhullah commented 6 months ago

Hello @agilgur5, how to make the build job run here?

agilgur5 commented 6 months ago

As the GitHub interface says, it requires an approval from a maintainer: Screenshot_2024-03-08-10-37-29-13_40deb401b9ffe8e1df2f1cc5ba480b12

I still do not have maintainer permissions for this repo, so I can't do anything. I'm also a Workflows maintainer, not a CD maintainer, so this PR would not necessarily fall under my purview either.

Closes [ISSUE #17436]

Also please use a full link to the CD issue: https://github.com/argoproj/argo-cd/issues/17436. A raw issue number does not work across different repositories. The proper GitHub syntax is also "Closes #x", not "Closes [ISSUE #x]"

github-actions[bot] commented 3 months ago

Stale pull request message

github-actions[bot] commented 2 months ago

This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open.