argoproj / argo-ui

Argoproj shared React components
Apache License 2.0
220 stars 178 forks source link

fix: Use type export for interface reexports #552

Closed instauro closed 3 months ago

instauro commented 4 months ago

Resolves the argo-ui related TS warnings described in https://github.com/argoproj/argo-workflows/issues/13009

Related webpack issue https://github.com/webpack/webpack/issues/7378 giving some background

agilgur5 commented 4 months ago

Ah right, I remember why I couldn't do this before, b/c it broke lint as I mentioned in https://github.com/argoproj/argo-workflows/pull/12514, since this repo was still on legacy tslint which didn't support the import type syntax. But I did eventually unblock that by migrating to ESLint in #509