argoproj / argo-ui

Argoproj shared React components
Apache License 2.0
220 stars 178 forks source link

Copy from logs using Ctrl-C doesn't work on Linux & Windows #557

Closed Adrien-D closed 3 months ago

Adrien-D commented 3 months ago

All the details for this issue are here https://github.com/argoproj/argo-workflows/issues/12947

I dug into this issue ans it's due to the Terminal from xterm in LogsViewer component that catches Keyboard events. This bug is still in an open state on xterm repo, and seems to be a desired behavior, so no real need to update it.

As a workaround I'll implement something inspired from https://github.com/xtermjs/xterm.js/issues/2478#issuecomment-1002371588