search

argoproj / argo-ui

Argoproj shared React components
Apache License 2.0
220 stars 178 forks source link

Autocomplete component is too aggressive on opening #559

Closed Adrien-D closed 3 months ago

Adrien-D commented 3 months ago

When opening the Autocomplete complete it auto highlight the first item, so when you hit enter it select the first item and not what you freely search into the input.

My proposal is to simply remove this behavior that is misleading users.

agilgur5 commented 3 months ago

An example would have been good context here. I checked the upstream docs for what autoHighlight does and it is also default true there (although it is also very dated and archived).

this behavior that is misleading users.

Similarly, an example here. argo-ui is a component library (ish), so it generally should not be prescriptive. There are use-cases where autoHighlight could be correct behavior, so to accurately make a broad statement like that would require checking all existing usage of it, which I don't believe you did (as there are no links here).

See my suggestion to retain backward-compat in https://github.com/argoproj/argo-ui/pull/560#pullrequestreview-2100517218