search

argoproj / argo-ui

Argoproj shared React components
Apache License 2.0
220 stars 178 forks source link

fix(navigation): invalid redirection #565

Closed KSH-code closed 1 month ago

KSH-code commented 2 months ago

fix #564

When I discover applications on like https://argocd.com/service/applications/, search applications and then click it. But it is redirected to https://argocd.com/service/applications//{application-name}. And an empty page is shown.

for the soultion, the slash in the end has to be removed.

KSH-code commented 2 months ago

Hi @agilgur5 Could you please give me feedback about this pr for merging? Thanks!

agilgur5 commented 1 month ago

I can take a look, but I'm not a CD Maintainer so I wouldn't merge on my own in any case. It would be good to link to an issue upstream as well per #453

KSH-code commented 1 month ago

Thank you for your check. I've made an issue on https://github.com/argoproj/argo-cd/issues/19093 which includes referring this.

agilgur5 commented 1 month ago

I left a comment on your upstream issue; this is perhaps better addressed upstream than here: https://github.com/argoproj/argo-cd/issues/19093#issuecomment-2240032528

KSH-code commented 1 month ago

I agree. I close this so that I will address this issue on upstream.