argoproj / argo-workflows

Workflow Engine for Kubernetes

https://argo-workflows.readthedocs.io/

Apache License 2.0

15.04k stars 3.2k forks source link

ui: show log line numbers + allow deep links #11017

Open or-shachar opened 1 year ago

or-shachar commented 1 year ago

Summary

I think it can be awesome if the UI would have line numbers for each output log line and allow deep linking into a specific line.

(photo taken from Github Action but almost every common workflow / CI engine has this feature)

Use Cases

Looking at a very long log output may be hard.
Sometimes you want to share a link to a specific line in the output showing the problem.

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

terrytangyuan commented 1 year ago

This should be straightforward to support in the UI. Would anyone like to submit a PR?

agilgur5 commented 1 year ago

Argo CD UI logs have line numbers, but not deep linking I think. Ideally we should follow similar style where possible, so can make line numbers similar. And deep linking could potentially be contributed to Argo CD as well (although CD logs are different with only first 100 lines etc showing).

or-shachar commented 3 weeks ago

@agilgur5 argocd UI logs can also be opened to fuller screen. @terrytangyuan I wish I had enough frontend skills to handle this myself but I don't