Open or-shachar opened 1 year ago
This should be achievable via https://github.com/argoproj/argo-workflows/pull/10808.
@terrytangyuan - Awesome!
@rbreeze - looks amazing!
Excuse my frontend ignorance, but will this make the link open up in a new tab / reload the page?
...this.state.links.map(link => ({
title: link.name,
iconClassName: 'fa fa-external-link',
action: () => (window.location.href = link.url)
If so - maybe we should add another type of link that simply changes the filter on the current view without reloading the page?
WDYT?
I think it opens up a new tab. cc @rbreeze @jiachengxu who contributed this for feedback.
If a way of filtering without reloading the page is added by config map, it will be convenient because the filters set by the user on the UI will be maintained. However, I think it could cause confusion if the filtering button is located at the same level as the existing reload button. So it would be better to use the existed way to redirect url.
If so - maybe we should add another type of link that simply changes the filter on the current view without reloading the page?
that could be done as a field on the links
spec. e.g. newTab: true
or something
Summary
Use Cases
Problem
Suggested solution:
Maybe as part of the configmap I can provide something like this:
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.