search

argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.04k stars 3.2k forks source link

Release v3.4 patch releases discussion #11851

Open terrytangyuan opened 1 year ago

terrytangyuan commented 1 year ago

This issue tracks commits for v3.4 patch releases.

agilgur5 commented 1 year ago

Do we want to cherry-pick in my UI date filter fixes? i.e. #11742, #11792, #11840

If so, I think I'd want to make another PR to remove the date filter default from the upgrade notes modal (as #11840 removes the default)

terrytangyuan commented 1 year ago

Sure I think we'll include all fixes if there's no conflict.

terrytangyuan commented 1 year ago

We need to include https://github.com/argoproj/argo-workflows/pull/11971 to unblock the build.

terrytangyuan commented 1 year ago

@juliev0 and @sarabala1979 suggests including https://github.com/argoproj/argo-workflows/pull/11774

terrytangyuan commented 1 year ago

We are targeting end of next week for this. Please comment if you’d like to prioritize any other fixes.

agilgur5 commented 1 year ago

Sure I think we'll include all fixes if there's no conflict.

Ok, I added #11982 on top of those since they'll be included in a 3.4.x release then (the upgrade note in the modal is only for 3.4)

@juliev0 and @sarabala1979 suggests including #11774

isn't that a feature though?

terrytangyuan commented 1 year ago

From @juliev0:

Without it, users in a cluster with too many sso groups can't log in to Argo Server.

So we could consider that a fix.

terrytangyuan commented 1 year ago

Security fix https://github.com/argoproj/argo-workflows/pull/11986

terrytangyuan commented 1 year ago

https://github.com/argoproj/argo-workflows/pull/11993

terrytangyuan commented 1 year ago

Working branch https://github.com/argoproj/argo-workflows/commits/release-3.4.12

terrytangyuan commented 1 year ago

Tag created: https://github.com/argoproj/argo-workflows/releases/tag/v3.4.12 Images will be published once CI succeeds: https://github.com/argoproj/argo-workflows/actions/runs/6587281270/job/17897237879

terrytangyuan commented 1 year ago

Released

terrytangyuan commented 1 year ago

Reusing this issue to track any potential bug fixes for future v3.4 patch releases.

terrytangyuan commented 1 year ago

From @juliev0, https://github.com/argoproj/argo-workflows/commit/75bd0b83a479997da1940e048d5161b11cecb303

terrytangyuan commented 1 year ago

Security fix https://github.com/argoproj/argo-workflows/pull/12111

terrytangyuan commented 1 year ago

Released: https://github.com/argoproj/argo-workflows/releases/tag/v3.4.13

terrytangyuan commented 1 year ago

TODOs:

agilgur5 commented 12 months ago

12172 specifically for the 3.4.x patch series

terrytangyuan commented 11 months ago

https://github.com/argoproj/argo-workflows/pull/12133

agilgur5 commented 11 months ago

12201 as the original PR was accidentally cherry-picked into 3.4.x when it was a fix for a 3.5.x feature.

juliev0 commented 11 months ago

Sorry, I forgot to ask before to merge this one: https://github.com/argoproj/argo-workflows/pull/11470/files (no hurry)

terrytangyuan commented 11 months ago

As discussed in today's contributors meeting, for v3.4 patch release, I will only cherry-pick the additional commits mentioned in the comments on this issue.

terrytangyuan commented 11 months ago

Commits to include in v3.4.14 release:

terrytangyuan commented 11 months ago

Working branch https://github.com/argoproj/argo-workflows/tree/release-3.4.14

juliev0 commented 11 months ago

requesting this be incorporated as well: https://github.com/argoproj/argo-workflows/pull/12203 (this is based on a Regression issue called out in 3.5.1 but I assume it also applies to 3.4.13, which is where it was noticed by someone at Intuit)

terrytangyuan commented 11 months ago

requesting this be incorporated as well: #12203 (this is based on a Regression issue called out in 3.5.1 but I assume it also applies to 3.4.13, which is where it was noticed by someone at Intuit)

It's already patched in https://github.com/argoproj/argo-workflows/pull/12201 to release-3.4.14 branch

terrytangyuan commented 11 months ago

v3.4.14 tag created https://github.com/argoproj/argo-workflows/releases/tag/v3.4.14

calvinwiebe commented 11 months ago

May I request #12281 be included in the next 3.4 patch? Upgrading to 3.5 caused some issues we don't have cycles to debug at the moment and would prefer to remain on 3.4 if we could. Thanks!

juliev0 commented 10 months ago

Request to include https://github.com/argoproj/argo-workflows/pull/12353

terrytangyuan commented 10 months ago

This needs to be included https://github.com/argoproj/argo-workflows/pull/12470

sarabala1979 commented 10 months ago

I am working on releasing v3.4.15 patch that includes https://github.com/argoproj/argo-workflows/pull/12470 https://github.com/argoproj/argo-workflows/pull/12353 https://github.com/argoproj/argo-workflows/pull/12281

@terrytangyuan @agilgur5 @juliev0 Let me know if you need to include any other PRs

sarabala1979 commented 9 months ago

@calvinwiebe https://github.com/argoproj/argo-workflows/pull/12281 has depended on another PR which has spec change. I would recommend upgrading v3.5 which is more stable now.

agilgur5 commented 9 months ago

~#12397 would be good to have for any patch~

EDIT: that appears specific to the merging of archived + live workflows in 3.5, so nvm

sarabala1979 commented 9 months ago

Released https://github.com/argoproj/argo-workflows/releases/tag/v3.4.15 contains below commits b3aaaa45d chore(build): Replaced master to main in changelogs fbf933563 fix: Resolve vulnerabilities in axios (#12470) feb992505 fix: liveness check (healthz) type asserts to wrong type (#12353) edb0a98c3 fix(docs): release-3.4 readthedocs backport (#12474)

sarabala1979 commented 9 months ago

12397 would be good to have for any patch

this commit requires other UI PR need to be cherry-picked which has UI file conflicts. Can you ask user to pick v3.5?

terrytangyuan commented 9 months ago

We might need another patch ASAP https://github.com/argoproj/argo-workflows/pull/12515

terrytangyuan commented 9 months ago

Released https://github.com/argoproj/argo-workflows/releases/tag/v3.4.16

agilgur5 commented 9 months ago

Another vuln #12556 (which is actually from a new go-git dep after #12515)

agilgur5 commented 9 months ago

12397 would be good to have for any patch

this commit requires other UI PR need to be cherry-picked which has UI file conflicts. Can you ask user to pick v3.5?

Yea this was my bad, it appears to only apply to 3.5 actually (I didn't realize that as it wasn't the Workflow List but the Workflow Details page, apparently that too was merged in 3.5). I edited my comment. Sorry about that!

drawlerr commented 9 months ago

Could #12233 be included the next v3.4 patch release?

agilgur5 commented 9 months ago

12492 would be good for any patch release

tachylatus commented 9 months ago

Could you please include #11847 in the next patch release? Our workflow-controller is susceptible to crashing with "was unable to obtain node for ...".

agilgur5 commented 9 months ago

12622 is a workaround for a (very impactful) k8s 1.27 issue (#11657)

agilgur5 commented 8 months ago

12652 adds some missing docs that are still relevant to release-3.4

agilgur5 commented 8 months ago

If it applies neatly, #12666 fixes a warning and performance issue

agilgur5 commented 8 months ago

12609 fixes a regression dating back to 3.3, so would be good to get into 3.5.x and 3.4.x

12581 is a docs clarification that would be helpful to backport

jackivanov commented 8 months ago

https://github.com/argoproj/argo-workflows/pull/12622 impact is significant, please release as soon as possible

agilgur5 commented 8 months ago

12683 fixes a regression from 3.4.7+

isubasinghe commented 7 months ago

Sorry for the delay, this took a bit more time than I thought, I was a bit sick last week so couldn't finish it. I've only just finished merging everything in.

Please help me check for correctness: https://github.com/isubasinghe/argo-workflows/tree/release-3.4.17

I will go through the commits again and confirm conflicts have been resolved correctly, will release tomorrow night AEDT if everything is okay.

terrytangyuan commented 7 months ago

Why not using release-3.4 branch? See the first paragraph in https://github.com/argoproj/argo-workflows/blob/main/docs/releasing.md