Open KataaOmar opened 4 months ago
The current design indeed ignores daemon failed. https://github.com/argoproj/argo-workflows/blob/934bf179a703a365a6a5eddfa6edb788492eac79/workflow/controller/operator.go#L1336
@shuangkun Is there a specific purpose for that? And what should we do in this case?
We also have a similar issue, how we can catch daemon failure via hook to send notifications? We have the same in DAG templates.
FYI, just added this comment in the PR: https://github.com/argoproj/argo-workflows/pull/12988#issuecomment-2105377768
Pre-requisites
:latest
What happened/what did you expect to happen?
Daemon pod is always succeeded even with a non-zero status code, I expect to find the daemon step failed, then the workflow as well.![image](https://github.com/argoproj/argo-workflows/assets/109907573/eecc1f19-4b13-4372-b5dc-e77c8145b90d)
Version
v3.5.5
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container