When workflow level retry expression evaluated False, workflow message is always `retryStrategy.expression evaluated to false` regardless of actual failure #13058
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
When workflow level retryExpression is used.
regardless of workflow succeed or failure,
the message at workflow level is always retryStrategy.expression evaluated to false
when no expression is used
workflow succeed -> no workflow message
workflow fail -> no more retry left
when expression is used
workflow succeed -> retryStrategy.expression evaluated to false
workflow fail (expression evaluated False) -> retryStrategy.expression evaluated to false
workflow fail (expression evaluated True) -> no more retry left
This is problematic if one relies on the workflow message for metrc, analytics or debug.
We expect when expression is used, the workflow level message follows the same pattern as normal retry
Pre-requisites
:latest
image tag (i.e.quay.io/argoproj/workflow-controller:latest
) and can confirm the issue still exists on:latest
. If not, I have explained why, in detail, in my description below.What happened/what did you expect to happen?
When workflow level retryExpression is used. regardless of workflow succeed or failure, the message at workflow level is always
retryStrategy.expression evaluated to false
when no expression is used
no more retry left
when expression is used
retryStrategy.expression evaluated to false
retryStrategy.expression evaluated to false
no more retry left
This is problematic if one relies on the workflow message for metrc, analytics or debug. We expect when expression is used, the workflow level message follows the same pattern as normal retry
Version
v3.5.2, latest (https://github.com/argoproj/argo-workflows/commit/71f1d860b2c665ad87e8c313c4f865b829d07626)
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container