agilgur5
commented
5 months ago Follow-up from this Slack thread.
I tried using
"{{workflow.labels.workflows.argoproj.io/cron-workflow}}"received error
MetricsError: unable to substitute parameters for metric 'exec_count': failed to resolve {{=workflow.labels['workflows.argoproj.io/cron-workflow']}}, unable to substitute parameters for metric 'exec_duration': failed to resolve {{=workflow.labels['workflows.argoproj.io/cron-workflow']}}value: "{{workflow.labels.workflows.argoproj.io/creator}}"
The description here seems to have copy+pasted a few different ones, so it's not exactly clear which variants you tried and which you didn't. All 3 of the above are different.
dot syntax works on plain Workflow (not CronWorkflow)
In the thread, @tico24 wrote that this works:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
generateName: wibblewobble-
spec:
metrics:
prometheus:
- name: exec_count
help: "Count of workflow execution by result status - workflow level"
labels:
- key: name
value: "{{workflow.labels.workflows.argoproj.io/creator}}"
- key: status
value: "{{workflow.status}}"
counter:
value: "1"but not when using as a workflowSpec of a CronWorkflow. Tim's hypothesis there was: "My assumption is that the metrics parameters are unpacked before the cron label is applied to the running workflow, so it can't find the label - hence the error. I would agree that this is an issue."
expr brackets syntax
I suggested using the expr style brackets, i.e. {{=workflow.labels['workflows.argoproj.io/cron-workflow']}}. Per the error it seems like that didn't work either, although not entirely clear due to copy+paste errors as per above
I'm also not sure if brackets are potentially affected by https://github.com/argoproj/argo-workflows/issues/11549
stephen-dahl
crileroro
Gitopolis
tvandinther
Pre-requisites
:latestimage tag (i.e.quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on:latest. If not, I have explained why, in detail, in my description below.What happened/what did you expect to happen?
https://cloud-native.slack.com/archives/C01QW9QSSSK/p1717447990226269
I tried using
"{{=workflow.labels['workflows.argoproj.io/cron-workflow']}}"as a metric label inside a workflow created by a cron and received errorMetricsError: unable to substitute parameters for metric 'exec_count': failed to evaluate expression "workflow.labels['workflows.argoproj.io/cron-workflow']"Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container