skipped dag node marked configmap error after its child node finishes

tczhao commented 4 months ago

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

node A were initially marked skipped as expected and proceed to execute B

after B completed, A is marked as error due configmap not found.

this behaviour only happens to dag template. Step template works fine.

We expect if a node is skipped, it shouldn't matter if the parameter refers to an empty configmap

Version(s)

3.5.2

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

metadata:
  name: a2
spec:
  templates:
    - name: echo2
      container:
        name: ''
        image: alpine:3.7
        command:
          - echo
          - abc
    - name: echo1
      inputs:
        parameters:
          - name: abc
            valueFrom:
              configMapKeyRef:
                name: abc
                key: abc
      container:
        name: ''
        image: alpine:3.7
        command:
          - echo
          - abc
    - name: diamond
      steps:
        - - name: A
            template: echo1
            when: 1 == 0
          - name: B
            template: echo2
            dependencies: [ A ]
  entrypoint: diamond

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

tczhao commented 4 months ago

problematic line https://github.com/argoproj/argo-workflows/blob/v3.5.2/workflow/controller/dag.go#L439

Joibel commented 4 months ago

The node.Fulfilled() criteria at https://github.com/argoproj/argo-workflows/blob/5b6ad2be163ecd3f0251a931ab84dba3c6085ad2/workflow/controller/dag.go#L429 feels like somethings in that block shouldn't apply to Skipped nodes.

tooptoop4 commented 1 week ago

where da logs?

have u tried after https://github.com/argoproj/argo-workflows/issues/13547 fix?

argoproj / argo-workflows

skipped dag node marked configmap error after its child node finishes #13329