argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
14.96k stars 3.19k forks source link

daemon containers don't support retry strategy #13705

Open MenD32 opened 1 week ago

MenD32 commented 1 week ago

Summary

daemon containers should be able to retry in order to ensure the stability of the workflow

Use Cases


Message from the maintainers:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

MenD32 commented 1 week ago

I'd also like to contribute to solve this issue

MenD32 commented 1 week ago

after looking at the code, i think a better fix would be to amend retry policy because of the createWorkflowPod function, which is kinda huge.

the something like retryStrategy: always

which i might add, doesn't work currently on daemon containers, from my testing