search

argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

Configure `terminationGracePeriodSeconds` without `podSpecPatch` #13716

Closed tooptoop4 closed 2 weeks ago

tooptoop4 commented 1 month ago

See https://github.com/argoproj/argo-workflows/issues/13671#issuecomment-2390274374

agilgur5 commented 1 month ago

Again, please fill out the issue template in full. It is there for a reason and not intended to be skipped, and active members of the community skipping it are showing poor role models to newer members (why should they fill it out if you don't? what's the point of a template then?).

It is also bad OSS practice and poor etiquette to skip templates in general.

See #13671 (comment)

Not to mention that this description is simply insufficient. This does not give a rationale and lists a bunch of other unrelated things too. I see one relevant sentence, which itself does not explain the rationale:

i see https://github.com/argoproj/argo-workflows/pull/4940 added terminationGracePeriodSeconds but it requires podSpecPatch which will slow things down

Again, as I and other maintainers and contributors have said before, more details is always good and a lack of details is difficult to even be actionable

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity and needs more information. It will be closed if no further activity occurs.

github-actions[bot] commented 2 weeks ago

This issue has been closed due to inactivity and lack of information. If you still encounter this issue, please add the requested information and re-open.