feat(artifactGC): include env, volumes, volumeMounts. Fixes #9746

argoproj / argo-workflows

Workflow Engine for Kubernetes

https://argo-workflows.readthedocs.io/

Apache License 2.0

15.11k stars 3.21k forks source link

feat(artifactGC): include env, volumes, volumeMounts. Fixes #9746 #13728

Open mrkschneider opened 1 month ago

mrkschneider commented 1 month ago

Fixes #9746

Motivation

This PR allows to provide credentials for artifact garbage collection via environment variables or mounted volumes.

Modifications

Introduce three new fields to ArtifactGC struct: Env,Volumes,VolumeMounts
The new fields are taken into account when grouping artifacts by credential set in artifact_gc.go
The new fields are also added to the cleanup pod performing garbage collection

Verification

added new fields to existing unit tests
submitted workflows with new fields and checked credential grouping + mounting of credentials in cleanup pod

mrkschneider commented 1 month ago

Build of argocli is failing in the pull request, though it succeeds locally on my machine. Can you please give me any advice on how to resolve the issue?

tooptoop4 commented 1 month ago

🔥

agilgur5 commented 1 month ago

Build of argocli is failing in the pull request

That appears to a new bug on main from #13343. It's unrelated to your change so you can ignore it, but will need to rebase once that is fixed.

MasonM commented 1 month ago

FYI: https://github.com/argoproj/argo-workflows/pull/13730 should fix the build failures

mrkschneider commented 1 month ago

Build of argocli is failing in the pull request

That appears to a new bug on main from #13343. It's unrelated to your change so you can ignore it, but will need to rebase once that is fixed.

rebasing on main fixed it, thanks!