fix(controller): handle case of configmap already exists on offload EnvVarTemplate. Fixes #13755

argoproj / argo-workflows

Workflow Engine for Kubernetes

https://argo-workflows.readthedocs.io/

Apache License 2.0

15.11k stars 3.21k forks source link

fix(controller): handle case of configmap already exists on offload EnvVarTemplate. Fixes #13755 #13756

Closed fyp711 closed 1 month ago

fyp711 commented 1 month ago

Fixes #13755

Motivation

if workflow pod used offload envVarTemplate, when pod create failed, and a transient error occurred. The pod will retry on moment, then this node will failed with IsAlreadyExists error.

Modifications

We should process Already Exists error

Verification

The best way to verifiy is constructing a too lang template, and than simulate a transient error

Joibel commented 1 month ago

Thanks for this, and for testing 3.6