search

argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

fix: better error message for multiple workflow controllers running #13760

Closed gregsheremeta closed 4 weeks ago

gregsheremeta commented 1 month ago

Motivation

Per various GitHub issues and personal experience, the expected < 2 pods, got 2 - this is a bug error message mostly happens these days when users accidentally have multiple workflow controllers running. This is usually caused by a bad install, e.g. installing a cluster-wide Argo Workflows alongside a namespace-scoped one, and having both controllers reconciling Workflows.

Modifications

Improve the error message to advise users to check for this.

Verification

I didn't verify this, since it's just a text change.

gregsheremeta commented 4 weeks ago

who can merge? This is my first contribution :) edit: ah, needs rebase

terrytangyuan commented 4 weeks ago

Thanks Greg!